Search filter "No filtered data found" message added + Dropdown close/reopen issue fixed #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninilo97
changed the title
ninilo97
changed the title
|
@NileshPatel17 Please review this pull request. |
|
Generally it should be one PR per issue fixed instead of putting multiple unrelated changes in a single PR. Also if you're removing code, like the call to |
|
@NileshPatel17 did you mean to commit that commented out line of code instead of just deleting the line? |
|
@rooby agree, will remove it.. |
|
@NileshPatel17 Also, the commented out line is still there in the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1]
Shows new placeholder text when no data is found during a search.
Shows :
Instead of
[2]
closeDropdown() is not required in "blur" hostlistener as it is already covered in [clickOutside] ClickOutsideDirective.
Turns out this closeDropdown was causing #198 #295 #302 and #309
Reference:
[1] Pipe filter empty check
[2] YHGxG's comment in issue thread